Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast DenpendenciesStream.url as String #145

Merged
merged 5 commits into from
Jun 15, 2022
Merged

Cast DenpendenciesStream.url as String #145

merged 5 commits into from
Jun 15, 2022

Conversation

SBurwash
Copy link
Contributor

Ticket (DE-291)

What

Dependencies url is cast as integer instead of string → Causes tap to fail

from tiguidou with ❤️

@ericboucher
Copy link
Contributor

Thanks @SBurwash, nice catch. Can you undo your changes to .gitignore? Then we should be gtg

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ericboucher ericboucher marked this pull request as ready for review June 15, 2022 10:48
@ericboucher ericboucher changed the title Cast DenpendenciesStream...url as String Cast DenpendenciesStream.url as String Jun 15, 2022
@ericboucher ericboucher merged commit 734e31d into MeltanoLabs:main Jun 15, 2022
@ericboucher
Copy link
Contributor

Thanks @SBurwash for your contribution ❤️ 😃

@SBurwash SBurwash deleted the DE-291-tap-github-dependenciesstream-url-integer-string branch June 15, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericboucher ericboucher ericboucher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SBurwash @ericboucher